Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Crayfish-Commons dependency on symfony/security-core to allow 5.x #1903

Closed
seth-shaw-unlv opened this issue Sep 27, 2021 · 8 comments
Closed
Assignees
Labels
Repository: Crayfish Commons Issues pertaining to the repository:https://github.com/Islandora/Crayfish-Commons Status: Can’t reproduce Cannot be reproduced. Usually applied before the issue is closed. Type: enhancement Identifies work on an enhancement to the Islandora codebase

Comments

@seth-shaw-unlv
Copy link
Contributor

The Drupal ldap module major version 4.0, the only version with Drupal 9 support, conflicts with symfony/security-core < 5 resulting in a conflict with crayfish-commons which requires either 3.4 or 4.4. This means that those using LDAP for authentication are stuck on Drupal 8 until this is resolved.

I haven't yet checked what we need to do to make crayfish-commons work with symfony/security-core:^5, if anything.

Tagging @elizoller as the current crayfish-commons maintainer.

@seth-shaw-unlv seth-shaw-unlv added Repository: Crayfish Commons Issues pertaining to the repository:https://github.com/Islandora/Crayfish-Commons Type: enhancement Identifies work on an enhancement to the Islandora codebase labels Sep 27, 2021
@seth-shaw-unlv
Copy link
Contributor Author

I went looking but couldn't find a good listing of security-core API changes....

@elizoller
Copy link
Member

that ellipsis makes me think that you weren't successful

@seth-shaw-unlv
Copy link
Contributor Author

Indeed, I wasn't.

@elizoller
Copy link
Member

elizoller commented Sep 28, 2021

@seth-shaw-unlv can you give me more info on this one? what kind of environment are you running in? are you already on D9 in that env?
i spun up a playbook (d9) with ubuntu/focal64 and just ran composer require 'drupal/ldap:^4.0' and it succeeded with no trouble

@seth-shaw-unlv
Copy link
Contributor Author

This was a D8 install with ldap 3 updating to D9. Perhaps I should spin up a fresh D8 Islandora, enable ldap 3, and try upgrading to D9 w/ ldap 4.

@kstapelfeldt
Copy link
Member

Seth was updating an existing Islandora 1.0 site and had composer complain about this conflict. Eli tried to test and he was not able to reproduce. Where exactly is the hitch with the update progress?

@kstapelfeldt
Copy link
Member

kstapelfeldt commented Sep 29, 2021

From @jordandukart https://packagist.org/packages/grahl/ldap - Eli pulled islandora-dev and Seth pulled in tagged version. Seth will try to reproduce.

@seth-shaw-unlv
Copy link
Contributor Author

Okay. I took an isle-dc and modified the make local to give me a D8 and Islandora 1.1.1 before installing ldap:3.0.0-beta7. I then updated ldap to ^4 and nothing complained. I went the extra step and updated Islandora to ^2 and Drupal to ^9 and was able to get that to go.

So, can't reproduce. It must have been something weird I was doing with composer or my particular site. Closing as "can't reproduce".

@seth-shaw-unlv seth-shaw-unlv added the Status: Can’t reproduce Cannot be reproduced. Usually applied before the issue is closed. label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Repository: Crayfish Commons Issues pertaining to the repository:https://github.com/Islandora/Crayfish-Commons Status: Can’t reproduce Cannot be reproduced. Usually applied before the issue is closed. Type: enhancement Identifies work on an enhancement to the Islandora codebase
Projects
None yet
Development

No branches or pull requests

3 participants