Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

islandora_fits is out of sync with the rest of the codebase #1405

Closed
dannylamb opened this issue Jan 21, 2020 · 7 comments
Closed

islandora_fits is out of sync with the rest of the codebase #1405

dannylamb opened this issue Jan 21, 2020 · 7 comments

Comments

@dannylamb
Copy link
Contributor

islandora_fits currently resides in roblib's github organization, and is being developed for features that aren't mainline yet. We need to pin it down so it doesn't keep drifting on us. Right now, on a fresh install, I'm getting this:

[Tue Jan 21 14:27:43.053575 2020] [php7:notice] [pid 814] [client 10.0.2.2:48366] Uncaught PHP Exception Drupal\\Core\\Entity\\EntityStorageException: "Field field_fits_file is unknown." at /var/www/html/drupal/web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php line 847, referer: http://localhost:8000/media/add/image?edit%5Bfield_media_of%5D%5Bwidget%5D%5B0%5D%5Btarget_id%5D=2

This has indexing for multiple files for media, but none of that has been contributed to us yet. If we can't reasonably pin it down, then we need to maintain a fork or have it LSAP'd to us.

@dannylamb
Copy link
Contributor Author

Reverting to b8a126ebaa896402c6ba341047363a05857d0a60 worked out alright.

@dannylamb
Copy link
Contributor Author

@alxp @ajstanley @rosiel ^^ Any chance we can get a version sliced at that commit?

@ajstanley
Copy link
Contributor

Absolutely - I'll get it first thing in the morning.

@ajstanley
Copy link
Contributor

ajstanley commented Jan 21, 2020

Branch 8.x-1.x is good to go - anyone who wants the new model can go to newFileModel
(Sorry about that, I'd kept the changes in a new branch but merged prematurely)
Also copied it back to master, so old playbooks will still run.

@dannylamb
Copy link
Contributor Author

Neither 8.x-1.x or master are working 😢 You're referencing some fields we don't have. Can you tag b8a126ebaa896402c6ba341047363a05857d0a60 while we sort out how to move forward with all the content modeling changes?

@dannylamb
Copy link
Contributor Author

Turns out I can just reference it like so

islandora-rdm/islandora_fits:dev-master#b8a126ebaa896402c6ba341047363a05857d0a60

for the time being. A tag would be nicer but that'll keep us going until we manage to pull everything into the islandora org.

@dannylamb
Copy link
Contributor Author

dev-master works fine for now. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants