Openseadragon view mode sets the viewer to a small fixed width

[dannylamb]

This is for just when using the Openseadragon view mode for a single image or page, not a full paged content object.

[mjordan]

Just confirming this behavior. Running carapace at commit 515b9194641a1798c549ce8eb9253b7713fca86d.

[dflitner]

.node .field-type-image__item is set to inline_block. Removing this makes the viewer go full screen width. Is that the desired behavior?

At any rate, that rule is set in node.css and rather than remove it and perhaps upset other images that are supposed to be inline-block, we can do:
.field-formatter-openseadragon-image .field-type-image__item {
display: initial;
}
to override it for Open Seadragon.

[dannylamb]

@dflitner can haz PR?

[dflitner]

Sorry thought I had already made this a PR. It was sitting on my local machine.

[dflitner]

Per Seth's suggestion, I'm looking at changing the CSS in Open Seadragon instead of Carapace. However I'm not sure what the desired behavior actually is. We have a manual height set of 640px because otherwise OSD shrinks down to tiny for some reason. It's supposed to match the size of the containing element, which is why changing .field-type-image__item was working. (P.S. adding width:100% to this also works instead of changing the display)

With the previous change and anything else I try to make the thing display bigger, it actually stretches out the image that it's displaying. Is it supposed to show the original image at its original size or is it meant to display at a certain size even if it's pixelly?

In my opinion, the ideal display behavior would be to display the image at its original size up to the width of the content area.

Perhaps I'm only noticing this because I'm using ancient internet memes as sample images.

Image with no viewer:
Image is 420x290px

Image with OSD at full width:
Hard to see in the screenshot but it's got visual artifacts.

I'm still poking at this but it's being annoying.

[seth-shaw-unlv]

Resolved with Islandora/openseadragon@ad2d2d1. Thanks @dflitner!