Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal.org hates our release tags #1225

Open
dannylamb opened this issue Jul 19, 2019 · 8 comments
Open

Drupal.org hates our release tags #1225

dannylamb opened this issue Jul 19, 2019 · 8 comments
Labels
Type: documentation provides documentation or asks for documentation. Type: enhancement Identifies work on an enhancement to the Islandora codebase

Comments

@dannylamb
Copy link
Contributor

Although at some point I read that you could name a tag anything, it's looking like if I want the release to show up on Drupal.org, it has to be renamed to 8.x-1.0 (no 1.0.0) and be based off of a non-master branch (I specifically chose master as the stable branch).

I'm not sure how best to proceed. Those tags must remain for packagist and our current install. I'm thinking i'll splice off branches from the tagged commits with different names, and release off of those on Drupal.org.

@dannylamb
Copy link
Contributor Author

https://www.drupal.org/node/1015226 for reference

@alxp
Copy link
Contributor

alxp commented Jul 19, 2019

If something is on Drupal.org, composer can find it with the 'Drupal/' prefix so packages is no longer necessary unless I'm missing another use for it

@whikloj
Copy link
Member

whikloj commented Jul 19, 2019

Looks like we need to have our 1.0.0 release tag called 6.1.0
https://www.drupal.org/docs/8/distributions/degov/semantic-versioning-model

@whikloj
Copy link
Member

whikloj commented Jul 19, 2019

Oh no, sorry that is for the deGov distribution. Mea culpa

@elizoller
Copy link
Member

maybe the new semantic versioning proposal from TAG will fix this?

@dannylamb
Copy link
Contributor Author

This should be a moot point because Drupal.org now actually uses semantic versioning for Drupal 9+. As long as we stick to 'standard' semantic versioning, we should be alright. I'd wait until we actually push stuff over to Drupal.org before closing the ticket though.

@whikloj
Copy link
Member

whikloj commented Sep 23, 2021

There are 2 things that need to happen

  1. we need our branch to be 2.x or 2.1.x to be viewed as the development branch for the current work on Drupal's repo.
  2. we need to consider how badly we want to work in the Drupal ecosystem, we need to either work in or synchronize to Drupal's code repository, migrate to DrupalSpoons or skip the whole thing.

I'm thinking that synchronizing is the simplest for the community as they don't need to learn anything new. Not sure how we might get Github actions to do that for us without too much trouble.

Another question becomes how we can incorporate any patches from the Drupal community back into the code.

Sidenote: @dannylamb can you add me to the JSON-LD drupal project and whatever other ones are up there. I pushed out the 2.0.0 release for islandora core on to Drupal.org and was going to work to release the rest when I had time. But I only have permissions to core islandora.

@kstapelfeldt kstapelfeldt added Type: documentation provides documentation or asks for documentation. Type: enhancement Identifies work on an enhancement to the Islandora codebase and removed documentation labels Sep 25, 2021
@rosiel
Copy link
Member

rosiel commented Oct 4, 2021

TAG is, after discussion with the tech call, going to rename branches to align with semantic versioning.
In particular, a new 2.x branch will be cut from the 8.x-1.x branch on all drupal-related code. This 2.x branch will be made the github default branch and will be our working branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: documentation provides documentation or asks for documentation. Type: enhancement Identifies work on an enhancement to the Islandora codebase
Projects
Development

No branches or pull requests

6 participants