Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we still need to support importing from fedora 5 to fedora 6? #368

Closed
joshdentremont opened this issue Nov 17, 2023 · 1 comment · Fixed by #369
Closed

Do we still need to support importing from fedora 5 to fedora 6? #368

joshdentremont opened this issue Nov 17, 2023 · 1 comment · Fixed by #369

Comments

@joshdentremont
Copy link
Contributor

In the makefile, the fcrepo import command runs fcrepo-upgrade-utils if FEDORA_6 is set to true in your .env. This is only necessary if the export you are using came from a version older than fedora6. At the moment this is causing some errors and stopping the import from working.

I have an issue in for buildkit to update fcrepo-upgrade-utils, which should stop this error (Islandora-Devops/isle-buildkit#304), but in conversation with Jared, he said that we don't need to run this on imports coming from fedora6. (https://islandora.slack.com/archives/CM6F4C4VA/p1700229939782089?thread_ts=1700076858.075639&cid=CM6F4C4VA)

I'm wondering if we can remove that check in the Makefile now, to stop this from being a problem again in the future as we continue to upgrade fedora? This would only be a change to the Makefile, and if someone was trying to import from 5 to 6 they would just have to add their own makefile commands manually.

@joshdentremont
Copy link
Contributor Author

Based on conversation at tech call we determined this should be removed, but we should make a note for anyone importing to fedora 6 from an older version, or have separate make commands for fedora 6 and fedora 5.

#369 should solve this by adding new import and export commands, and renaming the old ones to still be available for anyone using fedora 5, or needing to upgrade from 5 to 6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant