Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config from module #6

Closed
wants to merge 2 commits into from
Closed

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Aug 28, 2018

GitHub Issue: Islandora/documentation#902

Related PR: Islandora/documentation#98

This PR removes the configuration and moves it to a feature in the Islandora module (above PR).

See there for more information.

@seth-shaw-unlv @Islandora-CLAW/committers

@seth-shaw-unlv
Copy link
Contributor

Oh, yeah, forgot about those.

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but am I going to mess up any inflight issues by merging this? @Natkeeran in particular, are you cool if I merge?

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attempting to install the module without the default config caused a crash: Got error 'PHP message: Uncaught PHP Exception Symfony\\Component\\Routing\\Exception\\RouteNotFoundException: "Route "auto_entitylabel.settings" does not exist." at /var/www/drupalvm/drupal/web/core/lib/Drupal/Core/Routing/RouteProvider.php line 202

Also, the sub-module name needs to include the name of the parent module so it is clear on the Drupal 'Extend' page.

@seth-shaw-unlv
Copy link
Contributor

I must have applied the PR incorrectly... it doesn't make sense why that error should appear.

@seth-shaw-unlv seth-shaw-unlv dismissed their stale review August 29, 2018 15:52

I must have applied the PR wrong. It works directly cloning the branch.

@whikloj
Copy link
Member Author

whikloj commented Aug 29, 2018

I'm going to have to re-export this feature now anyways. Should I wait for #4 before I do this work?

@seth-shaw-unlv
Copy link
Contributor

@whikloj probably. Although I haven't seen @Natkeeran around today, so we might have to wait unless someone else wants to click the merge button.

@seth-shaw-unlv
Copy link
Contributor

@whikloj once that schema config is merged this PR should pull it over into the new feature submodule.

While we are at it, could we add "Controlled Access Terms" to the sub-module name in info.yml? Thanks.

@dannylamb
Copy link
Contributor

Superseded by 66bab1a

@dannylamb dannylamb closed this Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants