Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support audio formats #58

Merged
merged 1 commit into from
Feb 8, 2019
Merged

support audio formats #58

merged 1 commit into from
Feb 8, 2019

Conversation

Natkeeran
Copy link
Contributor

@Natkeeran Natkeeran commented Feb 4, 2019

GitHub Issue: (link)

What does this Pull Request do?

This PR adds configuration to enable creation of audio derivative files using Homarus/ffmpeg.

How should this be tested?

The easiest way to test this component alone would be to replace the following with the ones in the PR.

  • Homarus/src/Controller/HomarusController.php

Create an audio file in Fedora. Then issue the following curl command:

curl -H "Authorization: Bearer islandora" -H "Accept: audio/mpeg" -H "X-Islandora-Args: -codec:a libmp3lame -q:a 5" -H "Apix-Ldp-Resource:http://localhost:8080/fcrepo/rest/2019-02/input3.wav" http://localhost:8000/homarus/convert --output output.mp3

Interested parties

@dannylamb
@MarcusBarnes
@Islandora-CLAW/committers

@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #58   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      122    122           
=======================================
  Files             9      9           
  Lines           570    570           
=======================================
  Hits            570    570
Impacted Files Coverage Δ Complexity Δ
Homarus/src/Controller/HomarusController.php 100% <100%> (ø) 12 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8276680...e94dcab. Read the comment docs.

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! Just made an mp3 from a wave no prob.

:shipit:

@dannylamb dannylamb merged commit d81724e into Islandora:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants