ISSUE-149: Changed final response in Collection Service #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved islandora resource service /members link header to rel="member" Moved fedora REST's API location to rel="alternate", moved the base pcdm collection object's islandora resource service url to Location header and body.
| $putHeaders['Link'] = array('<'.$urlRoute.$tmpUuid.'/members>; rel="member"'); | ||
| $putHeaders['Location'] = array($urlRoute.$tmpUuid); | ||
| //Should i care about the etag? | ||
| return new Response($putHeaders['Location'][0], 201, $putHeaders); |
There was a problem hiding this comment.
As in should we create an etag here? Or something else?
There was a problem hiding this comment.
Not sure, we are returning the "etag" fedora4 gave us for the indirect container, but our response mutated to be a mixed thing of indirect and pcdm collection responses. So it's just a comment because i don't know what the use of stags during resource creation is (we are not caching this, etags make more sense when asking for resources). Anyway, i suppose @daniel-dgi will know better and remove my comments when moving towards a service provider
Changed rel="member" to rel="hub" using ianas's predefined vocal for this. @see http://www.iana.org/assignments/link-relations/link-relations.xhtml
ruebot
added a commit
that referenced
this pull request
Feb 19, 2016
ISSUE-149: Changed final response in Collection Service
Closed
|
Coool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #149
and copied into body.