Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first pass at metadata documentation #1061

Merged
merged 3 commits into from
Apr 5, 2019
Merged

first pass at metadata documentation #1061

merged 3 commits into from
Apr 5, 2019

Conversation

seth-shaw-unlv
Copy link
Contributor

GitHub Issue: #1040

This PR is part of the March 2019 documentation sprint, and includes work on the user docs for metadata in Islandora 8 as outlined at https://docs.google.com/spreadsheets/d/1wI_K5Y0XJSIBXoJ84VxObcy8TT07TuypIE_P3C0rnzU/edit#gid=0.

Interested parties

@Islandora-CLAW/committers, esp @dannylamb as the reviewer.

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a read and it looks good. Love that you can quote the tip boxes!

Here's a smattering of edits for brevity/streamlining. Take what you think helps and ignore anything that sounds nitpicky. I tend to be brief when writing so I may lean too hard in that direction at times.

docs/user-documentation/metadata.md Show resolved Hide resolved
docs/user-documentation/metadata.md Outdated Show resolved Hide resolved
docs/user-documentation/metadata.md Outdated Show resolved Hide resolved
docs/user-documentation/metadata.md Outdated Show resolved Hide resolved
docs/user-documentation/metadata.md Outdated Show resolved Hide resolved
docs/user-documentation/metadata.md Outdated Show resolved Hide resolved
docs/user-documentation/metadata.md Outdated Show resolved Hide resolved
docs/user-documentation/metadata.md Outdated Show resolved Hide resolved
docs/user-documentation/metadata.md Outdated Show resolved Hide resolved
@dannylamb
Copy link
Contributor

Checking it out now @seth-shaw-unlv. Thanks.

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's pull it in :shipit:

@dannylamb dannylamb merged commit a47a1fc into Islandora:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants