Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UUID Param Converter #411

Closed
dannylamb opened this issue Nov 9, 2016 · 4 comments
Closed

Fix UUID Param Converter #411

dannylamb opened this issue Nov 9, 2016 · 4 comments
Assignees

Comments

@dannylamb
Copy link
Contributor

dannylamb commented Nov 9, 2016

Entities cannot be loaded by going to the 'uuid' route /islandora_uui/{uuid}, though we define one. The result is a 404.

How to test:

  • vagrant up
  • Create a fedora resourcce
    screenshot from 2016-11-09 15-48-46
  • Visit the devel tab and grab the UUID
    screenshot from 2016-11-09 15-49-16
  • Try to load localhost:8000/islandora_uuid/{your_uuid}. You should receive a 404.
    screenshot from 2016-11-09 15-50-24
  • Apply Add a README to install dir #6
    • vagrant ssh
    • cd /var/www/html/drupal/modules/islandora
    • git checkout -b dannylamb-uuid 8.x-1.x
    • git pull https://github.com/dannylamb/islandora.git uuid
    • cd /var/www/html/drupal
    • drupal cache:rebuild all
  • Try to load localhost:8000/islandora_uuid/{your_uuid}. You should receive a 200 and see the entity.
    screenshot from 2016-11-09 16-01-19
@dannylamb
Copy link
Contributor Author

dannylamb commented Nov 18, 2016

This pull #426 will update your submodules to the newest. Looks like we've got to be diligent about this every time we commit to the submodules.

@ruebot
Copy link
Member

ruebot commented Nov 18, 2016

@dannylamb or we can just do #424, and then we should be fine. Save the submodules for cutting a releases of the entire project, which was the original intention of them.

@dannylamb
Copy link
Contributor Author

#424 has landed and @Natkeeran and @ruebot have confirmed. Can someone move this one forward?

@ruebot
Copy link
Member

ruebot commented Nov 21, 2016

Resolved with: d0abe9a

@ruebot ruebot closed this as completed Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants