Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does openseadragon support responsive view? #1105

Closed
Natkeeran opened this issue Apr 26, 2019 · 2 comments
Closed

Does openseadragon support responsive view? #1105

Natkeeran opened this issue Apr 26, 2019 · 2 comments
Milestone
1.0.0

Comments

@Natkeeran
Copy link
Contributor

It seems like the width of the viewer is not adjusted for responsive mode. Does openseadragon supports responsive view?
@seth-shaw-unlv
Copy link
Contributor

Open Seadragon itself can be responsive; but the CSS provided by islandora/openseadragon has a set width of 600px.

Playing around with it a bit in Chrome's developer tools shows that you can remove the width descriptor and it will resize just fine (it inherits a 100% width). You do need a set height; but it doesn't have to be 640px.

A repository can locally override a module's CSS although we might consider just removing the width descriptor as a reasonable default.

What do you think, @whikloj?

@Natkeeran Natkeeran changed the title Does openseadragon supports responsive view? Does openseadragon support responsive view? May 1, 2019
@dannylamb dannylamb added this to the 1.0.0 milestone May 8, 2019
@seth-shaw-unlv seth-shaw-unlv mentioned this issue May 10, 2019
Merged
@dannylamb
Copy link
Contributor

Resolved via Islandora/openseadragon@d4d950c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@Natkeeran @dannylamb @seth-shaw-unlv