Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add javadocs deploy to Alpaca gradle build; Resolves https://github.c… #24

Merged
merged 6 commits into from
Dec 22, 2016
Merged

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Dec 21, 2016

@@ -78,6 +77,14 @@ subprojects {
from javadoc
}

task docs(type: Javadoc) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're actually going to want this block to be outside of the subprojects block -- it should be in the "top level" of the tasks, so just put it at the very end of the file.

@@ -170,14 +170,6 @@ subprojects {
url 'https://github.com/Islandora-CLAW/CLAW/issues'
}

distributionManagement {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually keep this block around, but you might need to change some of the values.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, feel free to remove this block.

@acoburn
Copy link
Contributor

acoburn commented Dec 21, 2016

You'll also want to remove this line: https://github.com/Islandora-CLAW/Alpaca/pull/24/files#diff-c197962302397baf3a4cc36463dce5eaL4

To verify that the docs task works, look in the ./docs directory and view the generated HTML

@ruebot
Copy link
Member Author

ruebot commented Dec 21, 2016

@dannylamb once this is merged, want me to do a release again to test out the gradle release machinery, and document it? Or, do you want to take a crack at it?

@dannylamb dannylamb merged commit e2d9267 into Islandora:master Dec 22, 2016
@dannylamb
Copy link
Contributor

@ruebot I'd like to take a crack at it

@ruebot ruebot deleted the issue-471 branch December 22, 2016 16:28
@ruebot
Copy link
Member Author

ruebot commented Dec 22, 2016

@dannylamb cool! This comment -- Islandora/documentation#471 (comment) -- should get you there, and I'll assign Islandora/documentation#470 to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants