[Feature Request] Add item "Preview PDF" to Options menu and show in a modal window #925
Comments
|
This would cause a problem when I'm working on a quote or invoice and I
want to see what it now looks like. Currently I can let the quote open in
the new tab, return to the first tab and edit the quote, then refresh the
second tab and see the changes. With this proposed change, I'd have to
constantly be closing and re-opening the modal which I think would be
troublesome.
=============================================
…On Sat, Feb 11, 2023 at 8:34 AM VeRony ***@***.***> wrote:
In several places (in Quotes and Invoices, among others) you can find the
"Options" dropdown menu.
Here you can select the menu item "Download PDF." The application then
jumps to a new tab window and the corresponding Quote or Invoice pdf is
displayed.
Expected Behavior
Choose the menu item "View PDF" which opens a modal window (with the PDF)
on top of the current page
Current Behavior
Menu item "Download PDF" opens a new tab window, jump to it and show the
PDF there
Screenshots
[image: image]
<https://user-images.githubusercontent.com/30659226/218269055-868b4420-ecbc-4f31-b332-c78b21d846ce.png>
Possible Solution
Replace the behavior of "Download PDF" with "View PDF" and show PDFs
anywhere in the application in a modal window
Context (Environment)
Each time you click on this menu item, a new tab window will open where
the pdf is displayed.
This is very confusing and you may have multiple tab windows open with
different pdf versions of the same Quote or Invoice as a result.
—
Reply to this email directly, view it on GitHub
<#925>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRVNOWCESBA4AQOJBPBCJTWW65PRANCNFSM6AAAAAAUYZAGPM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
I have to agree with @gaelicwinter. I believe the current functionality suffices and maybe we need to add a second button for "preview" and that would perform the action @Verony-makesIT has described above. |
|
If I follow @gaelicwinter procedure he performs following steps:
My suggestion:
Conclusion: Can't we leave the choice to the user which option they want to use by adding an additional setting [Download PDF in tab] or [View PDF in modal]? |
|
My 2 cents: Don't delete options, but add new ones: View PDF, or like clockwiseq said: To test the behaviour, don't rely on your own PC, there's an application called 'Browserstack' which will prepare your windows types, Mac types and several exotic browsers |
|
I think there is a misunderstanding somewhere.
Regarding your comment about viewing pdfs in the browser, I just want to point out that I do not want to introduce new techniques in IP but only use the same modal functionality that is present in IP since years. E.g. modal create invoice, add_invoice_tax, etc.. So nothing new, just instead of some text and form fields I show the pdfs in an iframe in the body of the modal. The pdfs are rendered with their own internal pdf browser engine. |
Verony-makesIT
changed the title
…odal-InvoicePlane#925" This reverts commit f6ca2df, reversing changes made to 70bac8c.
…PDF-in-Modal-InvoicePlane#925"" This reverts commit 87ddcc6.
In several places (in Quotes and Invoices, among others) you can find the "Options" dropdown menu.
Here you can select the menu item "Download PDF." The application then jumps to a new tab window and the corresponding Quote or Invoice pdf is displayed.
Expected Behavior
Choose the menu item "View PDF" which opens a modal window (with the PDF) on top of the current page
Current Behavior
Menu item "Download PDF" opens a new tab window, jump to it and show the PDF there
Screenshots
Possible Solution
Replace the behavior of "Download PDF" with "View PDF" and show PDFs anywhere in the application in a modal window
Context (Environment)
Each time you click on this menu item, a new tab window will open where the pdf is displayed.
This is very confusing and you may have multiple tab windows open with different pdf versions of the same Quote or Invoice as a result.
The text was updated successfully, but these errors were encountered: