Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters in the sign password cause ZXPSignCmd to fail #8

Open
dheidelberger opened this issue Jul 25, 2020 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@dheidelberger
Copy link

Hi Tom. First of all, the Brutalism component library is INCREDIBLE, congrats and thanks to you and Adam for putting it together.

This is a pretty minor thing, and I know it's in code you want to overhaul anyway, but just a heads-up, I was trying to sign an extension and I had my password manager generate a pw for me without thinking too much about what it was doing. The password had a & in it and that caused ZXPSignCmd to fail with the error "Arguments are invalid. Process failed." That makes sense because the & has a meaning in the terminal. I'm betting this can be fixed by wrapping the pw in quotes and I'm happy to submit a pull request when I have time (not for a little while). Meanwhile, documenting the issue here just in case others run into it.

@Inventsable
Copy link
Owner

Thanks so much 🙏

Good catch! I'd never noticed this because I tend to use decently simple passwords without special characters. Would definitely love a PR if not do it myself, glad to have this documented to save others trouble too. Thanks!

@Inventsable Inventsable self-assigned this Jul 25, 2020
@Inventsable Inventsable added the bug Something isn't working label Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants