You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi Tom. First of all, the Brutalism component library is INCREDIBLE, congrats and thanks to you and Adam for putting it together.
This is a pretty minor thing, and I know it's in code you want to overhaul anyway, but just a heads-up, I was trying to sign an extension and I had my password manager generate a pw for me without thinking too much about what it was doing. The password had a & in it and that caused ZXPSignCmd to fail with the error "Arguments are invalid. Process failed." That makes sense because the & has a meaning in the terminal. I'm betting this can be fixed by wrapping the pw in quotes and I'm happy to submit a pull request when I have time (not for a little while). Meanwhile, documenting the issue here just in case others run into it.
The text was updated successfully, but these errors were encountered:
Good catch! I'd never noticed this because I tend to use decently simple passwords without special characters. Would definitely love a PR if not do it myself, glad to have this documented to save others trouble too. Thanks!
Hi Tom. First of all, the Brutalism component library is INCREDIBLE, congrats and thanks to you and Adam for putting it together.
This is a pretty minor thing, and I know it's in code you want to overhaul anyway, but just a heads-up, I was trying to sign an extension and I had my password manager generate a pw for me without thinking too much about what it was doing. The password had a & in it and that caused ZXPSignCmd to fail with the error "Arguments are invalid. Process failed." That makes sense because the & has a meaning in the terminal. I'm betting this can be fixed by wrapping the pw in quotes and I'm happy to submit a pull request when I have time (not for a little while). Meanwhile, documenting the issue here just in case others run into it.
The text was updated successfully, but these errors were encountered: