-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Cardano Haskell package repository ("CHaP") #797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, hopefully the constraints will die in due course.
the failure doesn't seem to have anything to do with CHaP
|
That's the same error as #757 which tries to bump haskell.nix and hackage.nix. Is using CHaP making us use a more recent version of those packages? |
Andrea just bumped |
WUT? I force pushed and GitHub closed the PR. 🤷 I cannot reopen it. I'll open a new PR. Edit: oh I see what happened, |
-- Should follow cardano-node | ||
source-repository-package | ||
type: git | ||
location: https://github.com/input-output-hk/cardano-config | ||
tag: 1646e9167fab36c0bff82317743b96efa2d3adaa | ||
|
||
-- Should follow cardano-wallet. | ||
-- This is needed because we rely on an unreleased feature | ||
-- https://github.com/input-output-hk/cardano-ledger/pull/3111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding insult to the injury, cardano-ledger just got a new release out and that feature is not included 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, their new release is based on functionality that was done on August. Not really up to date. Don't know why though.
I had to reintroduce a srp for cardano-node because |
Are those packages that we depend on, or ones that the released packages depend on? We could probably release those now if they should have been released. |
Can we move to the Hackage |
we use cardano-submit-api in plutus-example, the other ones are transitive. We just released trace-dispatcher and trace-forward which are the critical ones. |
yes but it's not entirely trivial, we have ticket for that PLT-1239 |
I think this is the best we can do for the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to resolve the ledger issue before we can publish plutus-apps libs to CHaP, and also there's going to be a lot of local recompilation for folks still until we do, but I agree this is the best we can do for now 👍
-- Should follow cardano-node | ||
source-repository-package | ||
type: git | ||
location: https://github.com/input-output-hk/cardano-config | ||
tag: 1646e9167fab36c0bff82317743b96efa2d3adaa | ||
|
||
-- Should follow cardano-wallet. | ||
-- This is needed because we rely on an unreleased feature | ||
-- https://github.com/input-output-hk/cardano-ledger/pull/3111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, their new release is based on functionality that was done on August. Not really up to date. Don't know why though.
This PR replaces most
source-repository-package
stanzas in cabal.project with packages fetched from our Cardano Haskell package repository.Unfortunately some packages in CHaP still have broken version bounds so we need to manually specify a bunch of constraints to make sure we have a plan we can build.
I still need to revisit the documentation in
CONTRIBUTING
.