Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Github pull request template #495

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Updated Github pull request template #495

merged 1 commit into from
Jun 3, 2022

Conversation

koslambrou
Copy link
Contributor

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@koslambrou koslambrou requested review from a user and sjoerdvisscher June 3, 2022 15:06
sjoerdvisscher
sjoerdvisscher approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@sjoerdvisscher sjoerdvisscher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I could have done this myself! I thought it was an admin setting. 🤦 Sorry for asking you to do this!

@koslambrou
Copy link
Contributor Author

@sjoerdvisscher :D I thought so as well.

@koslambrou koslambrou merged commit 61de89d into main Jun 3, 2022
@koslambrou koslambrou deleted the kll/update-pr-template branch June 3, 2022 15:47
koslambrou added a commit that referenced this pull request Jun 22, 2022
@koslambrou
Updated Github pull request template (#495)
b5f3783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjoerdvisscher sjoerdvisscher sjoerdvisscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koslambrou @sjoerdvisscher