Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utxo indexer #493

Merged
merged 7 commits into from
Jun 10, 2022
Merged

Utxo indexer #493

merged 7 commits into from
Jun 10, 2022

Conversation

raduom
Copy link
Contributor

@raduom raduom commented Jun 2, 2022

This adds the Utxo indexer as an option to the Marconi binary.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@raduom raduom self-assigned this Jun 2, 2022
@raduom raduom changed the title Raduom/utxo index Utxo indexer Jun 2, 2022
@raduom raduom force-pushed the raduom/utxo-index branch 6 times, most recently from c5bbf21 to 1539cb7 Compare June 7, 2022 06:00
@raduom raduom marked this pull request as ready for review June 7, 2022 06:20
@raduom
Copy link
Contributor Author

raduom commented Jun 7, 2022

There is still some thought to be put in Indexer.hs, but the indexer itself is good enough to start reviewing. I am inclined not to change the code in Indexer.hs since it's going to go away when I start working on the issue that runs the indexers in parallel.

Copy link
Contributor

@andreabedini andreabedini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this integrate with the existing entry-point? As it stands now, you just replace the datum indexer with the new utxo indexer. How can I run both?

@raduom
Copy link
Contributor Author

raduom commented Jun 7, 2022

How does this integrate with the existing entry-point? As it stands now, you just replace the datum indexer with the new utxo indexer. How can I run both?

You can't. That is the next issue I have in the sprint.

@andreabedini
Copy link
Contributor

@raduom

You can't. That is the next issue I have in the sprint.

I didn't mean "at the same time". Let me rephrase that. How do I run the datum indexer after this is done.

Copy link
Contributor

@andreabedini andreabedini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need work to integrate with existing entry point (or create a new one).

@raduom
Copy link
Contributor Author

raduom commented Jun 8, 2022

Need work to integrate with existing entry point (or create a new one).

We will use some command line options to specify which indexer should be used.

@raduom raduom force-pushed the raduom/utxo-index branch 4 times, most recently from 2061f6e to fa2ecb8 Compare June 8, 2022 19:26
@raduom raduom merged commit ea10bbf into IntersectMBO:main Jun 10, 2022
@raduom raduom deleted the raduom/utxo-index branch June 10, 2022 11:45
koslambrou pushed a commit that referenced this pull request Jun 22, 2022
* Remove dependency on quickspec.

* Extract inputs and output from block

* Implement handlers.

* Move some things around.

* Remove dependency on fromCardanoTx.

* Add some lost queries.

* Add indexer options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants