Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCP-3445: fix chain index blocking #386

Merged
merged 13 commits into from
Apr 5, 2022
Merged

SCP-3445: fix chain index blocking #386

merged 13 commits into from
Apr 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 1, 2022

  • Adds a connection pool for sqlite
  • Reduces the scope of takeMVar blocking.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@ghost ghost requested review from sjoerdvisscher and koslambrou April 1, 2022 10:58
@ghost ghost mentioned this pull request Apr 1, 2022
Closed
8 tasks
@ghost ghost force-pushed the chain-index-fix-blocking branch from 415cb4e to c4f1488 Compare April 1, 2022 11:53
@koslambrou koslambrou mentioned this pull request Apr 1, 2022
Closed
sjoerdvisscher
sjoerdvisscher approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@sjoerdvisscher sjoerdvisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so that's how to do it! Thanks for figuring this out.

@ghost ghost requested a review from koslambrou April 5, 2022 16:49
@koslambrou koslambrou merged commit e4062bc into main Apr 5, 2022
@koslambrou koslambrou deleted the chain-index-fix-blocking branch April 5, 2022 16:50
bwbush pushed a commit that referenced this pull request Apr 15, 2022
@bwbush
SCP-3445: fix chain index blocking (#386)
1fb45dc 
* [chain-index]: replace chain index state's MVar with TVar

* [chain-index]: add sqlite connection pool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjoerdvisscher @koslambrou