ContractModel: Extend the Escrow contract model #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind having a quick look at this? @sjoerdvisscher |
plutus-use-cases/test/Spec/Escrow.hs
Outdated
| && Nothing /= (s ^. contractState . contributions . at w) | ||
| Pay w v -> Nothing == s ^. contractState . contributions . at w | ||
| Pay w v -> (True || Nothing == s ^. contractState . contributions . at w) -- disabled |
There was a problem hiding this comment.
Why is this disabled?
There was a problem hiding this comment.
It's disabled so that we can also test paying the amount due in several installments. The contract allows that, so there's no reason not to test it.
There was a problem hiding this comment.
(should have removed the condition altogether, of course).
Extend Escrow tests, add negative testing Add NoLockedFunds to Escrow tests
MaximilianAlgehed
force-pushed
the
PR-escrow-contract-model-improvements
branch
from
96ef2b8
to
284c6f2
Compare
sjoerdvisscher
approved these changes
Feb 11, 2022
|
@sjoerdvisscher I think this is ready to merge now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend Escrow tests, add negative testing
Add NoLockedFunds to Escrow tests
Pre-submit checklist: