Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContractModel: simplify starting contracts with parameters #278

Merged
merged 4 commits into from
Jan 28, 2022
Merged

ContractModel: simplify starting contracts with parameters #278

merged 4 commits into from
Jan 28, 2022

Conversation

MaximilianAlgehed
Copy link
Contributor

@MaximilianAlgehed MaximilianAlgehed commented Jan 25, 2022 •
edited
Loading

This fixes the previous uncomfortable interface to starting contracts in ContractModel tests.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@rjmh @MaximilianAlgehed
ContractModel: simplify starting contracts with parameters
0a25ca2 
Auction: improve test case distribution (more bids, fewer waits, reach maximum bid only 5% of time)
SealedBidAuction: introduce possibility of revealing with no previous bid
@MaximilianAlgehed MaximilianAlgehed marked this pull request as draft January 25, 2022 15:42
@MaximilianAlgehed MaximilianAlgehed marked this pull request as ready for review January 26, 2022 08:46
@MaximilianAlgehed
Copy link
Contributor Author

@sjoerdvisscher do you have time to have a look at this?

sjoerdvisscher
sjoerdvisscher approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@sjoerdvisscher sjoerdvisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love first class support for contracts with parameters, we should do that more too.

plutus-use-cases/test/Spec/GameStateMachine.hs Outdated Show resolved Hide resolved
@sjoerdvisscher sjoerdvisscher merged commit ce8282d into IntersectMBO:main Jan 28, 2022
@MaximilianAlgehed MaximilianAlgehed deleted the PR-simplify-start-contracts branch February 16, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjoerdvisscher sjoerdvisscher sjoerdvisscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaximilianAlgehed @sjoerdvisscher @rjmh