-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump hackage-nix & cabal index #269
Conversation
610bdb8
to
57eacf3
Compare
@@ -1,65 +1,65 @@ | |||
Slot 00000: TxnValidate 98d5fbcefe21113b3f0390c1441e075b8a870cc5a8fa2a56dcde1d8247e41715 | |||
Slot 00000: SlotAdd Slot 1 | |||
Slot 00001: W1bc5f27: InsertionSuccess: New tip is Tip(slot= Slot 1, blockId= BlockId(-3933910562423127441), blockNo= 0). UTxO state was added to the end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kk-hainq - do you know why these are changing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A newer hashable
version changed the default Hashable
instance of ByteString
:
https://github.com/haskell-unordered-containers/hashable/blob/747ff1b58b721fbf355ea1b1a9b66f531bf966e9/CHANGES.md?plain=1#L31-L34
Which affects PlutusTx.Builtins.Internal.BuiltinByteString
, then Plutus.V1.Ledger.TxId.TxId
, then the blockId
in Plutus.Trace.Emulator.System.appendNewTipBlock
:
https://github.com/input-output-hk/plutus-apps/blob/8574e9678d7288d3cc3bdafdfa425f5e096b77d4/plutus-contract/src/Plutus/Trace/Emulator/System.hs#L146-L150
Which eventually arrives at this log:
https://github.com/input-output-hk/plutus-apps/blob/8574e9678d7288d3cc3bdafdfa425f5e096b77d4/plutus-chain-index-core/src/Plutus/ChainIndex/Emulator/Handlers.hs#L189
Either way, good catch! The numeric, negative even block ids indeed look weird. I've replaced the ad-hoc hash function with the more "appropriate" blockId
function in the third commit: 76358f5.
- newer Hackage packages. - remove the last manual dep constraint in cabal.project thanks to new beam-migrate version fixing it.
57eacf3
to
76358f5
Compare
cabal.project
thanks to the newbeam-migrate
version fixing it.Pre-submit checklist: