Minting doesn't need special treatment after all #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoerdvisscher
force-pushed
the
sv/fix-263
branch
from
1679a20
to
d12e208
Compare
sjoerdvisscher
force-pushed
the
sv/fix-263
branch
from
d12e208
to
f4c9683
Compare
silky
reviewed
Jan 24, 2022
| @@ -405,52 +404,23 @@ handleBalanceTx utxo UnbalancedTx{unBalancedTxTx} = do | |||
| -- | Adjust the left and right balance of an unbalanced 'Tx' with the missing | |||
| -- lovelace considering the minimum lovelace per transaction output constraint | |||
| -- from the Cardano blockchain. | |||
| adjustBalanceWithMissingLovelace :: | |||
koslambrou
reviewed
Jan 24, 2022
| let val = vL 200 | ||
| lookups = Constraints.mintingPolicy coinMintingPolicy | ||
| constraints = Constraints.mustMintValue val | ||
| <> Constraints.mustPayToPubKey pkh (val <> Ada.toValue Ledger.minAdaTxOut) |
There was a problem hiding this comment.
If I'm understanding correctly, if the constraints is:
Constraints.mustMintValue val <> Constraints.mustPayToPubKey pkh val
instead, then the new balancing logic in the emulator will not try to add the min Ada to the output containing the minted token? So the transaction will just fail unless we call adjustUnbalanceTx?
There was a problem hiding this comment.
Yes, this is consistent with the other Constraints right?
There was a problem hiding this comment.
Yes it seems consistent! Thanks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263
Pre-submit checklist: