Add a swagger ui page for chain index endpoints #130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step forward for #129.
I have two questions:
OpenApi.ToSchema
instances with thenewtype
strategy like the following?https://github.com/input-output-hk/plutus-apps/blob/7333e3c3ae62c955c5db7799dbf1c1f58593325d/plutus-ledger/src/Ledger/Orphans.hs#L89
It is cleaner but will lead to imprecise schemas. For instance, the above
Slot
is returned withgetSlot
in the tip endpoint.The answer might be the other way around, to derive/write
ToJSON
through thenewtype
strategy more? Most things inOrphans
are inplutus
though.https://github.com/input-output-hk/plutus-apps/blob/7333e3c3ae62c955c5db7799dbf1c1f58593325d/plutus-chain-index-core/src/Plutus/ChainIndex/Api.hs#L110-L112
Should we write a dedicated data type for each case, at least for better
Aeson
andOpenApi
instances?Pre-submit checklist: