Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add walletPubKey #105

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Add walletPubKey #105

merged 1 commit into from
Dec 1, 2021

Conversation

jeffhappily
Copy link
Contributor

@jeffhappily jeffhappily commented Nov 12, 2021 •
edited
Loading

Fixes #104.

Added walletPubKey function and updated the original walletPubKeyHash function to use this function.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@zygomeb
Copy link

zygomeb commented Nov 15, 2021

cc @michaelpj

@ghost ghost requested a review from silky November 22, 2021 11:51
silky
silky approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@silky silky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@silky silky merged commit fc274c1 into IntersectMBO:main Dec 1, 2021
@jeffhappily jeffhappily deleted the wallet-pubkey branch December 2, 2021 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygomeb zygomeb zygomeb approved these changes

@silky silky silky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing walletPubKey function
3 participants
@jeffhappily @zygomeb @silky