Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write test checking whether effective peer targets are consistent with demanded ones #4911

Open
crocodile-dentist opened this issue Jul 11, 2024 · 0 comments
Labels
churn Issues / PRs related to churn testing

Comments

@crocodile-dentist
Copy link
Contributor

crocodile-dentist commented Jul 11, 2024

Churn and peer selection governors work together to establish the right peer targets for the node. This interplay is nuanced, considering that in Genesis consensus mode, there are two static targets bases to choose from, reflecting whether the node is caught up or still syncing. Churn has to pick the correct basis to modify and send to peer selection governor via a TVar, and OG has to make sure that it picks up these values from the TVar when churning is actively working, or whether to pick one of the targets bases when ledger state judgement changes. So the goal is to not lose information that churn provides, as well as to know when not to use targets from churn in case they are out-of-date.

@coot coot added the churn Issues / PRs related to churn label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
churn Issues / PRs related to churn testing
Projects
Status: No status
Development

No branches or pull requests

2 participants