Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Immutable DB independent from EpochSize #1699

Closed
edsko opened this issue Feb 25, 2020 · 2 comments
Closed

Make Immutable DB independent from EpochSize #1699

edsko opened this issue Feb 25, 2020 · 2 comments
Assignees
Labels
consensus issues related to ouroboros-consensus immutable db
Milestone

Comments

@edsko
Copy link
Contributor

edsko commented Feb 25, 2020

At the moment, the immutable DB stores blocks per epoch. Unfortunately, this introduces a dependency between the immutable DB and the ledger state, because the ledger state tells us when epoch sizes change. Instead we should give the immutable DB a fixed "chunk" parameter, with a precondition that if there are EBBs present, they must line up with the first slot in each chunk. Unfortunately, this means that the size of the files stored on disk will go down a factor of 10 or even 20 (depending on the choice of the Praos f parameter), but after discussing this with @dcoutts , we considered this an acceptable compromise.

This is blocking the work on the hard fork combinator; indeed, it is blocking the work at #1698 on #1637 / #1205 .

@edsko
Copy link
Contributor Author

edsko commented Feb 27, 2020

WIP PR at #1717.

@edsko
Copy link
Contributor Author

edsko commented Mar 9, 2020

Closed in #1750.

@edsko edsko closed this as completed Mar 9, 2020
@mrBliss mrBliss added this to the S8 2020-03-12 milestone Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus issues related to ouroboros-consensus immutable db
Projects
None yet
Development

No branches or pull requests

2 participants