Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test chain quality #797

Open
edsko opened this issue Feb 7, 2019 · 3 comments
Open

Test chain quality #797

edsko opened this issue Feb 7, 2019 · 3 comments
Labels
better-tests Ideas to improve the tests

Comments

@edsko
Copy link
Contributor

edsko commented Feb 7, 2019

At the moment we only check the common prefix property.

Related: #798.

@nfrisby
Copy link
Contributor

nfrisby commented Sep 12, 2019

Is there an existing document listing out these desired qualities/quantities in some detail?

All of the consensus tests currently only bound the length of each final chain's suffix beyond their common prefix. The upper bound on that suffix length is computed for each test case based on its configuration (eg join plan, a priori or a posteriori leader schedule, etc). The bound is conservative, since its computed without the details of the node configuration etc. When the bound is 0, the test case requires that the network ended in consensus.

@edsko
Copy link
Contributor Author

edsko commented Sep 12, 2019

"Quality" here refers to a technical definition as found in the Ouroboros papers.

@nfrisby
Copy link
Contributor

nfrisby commented Sep 12, 2019

Edsko found a list of the (relevant?) Ouroboros papers for me. I'm transcribing it here:

Name Listed Link Resolved as of 2019 September 12
BFT https://iohk.io/research/papers/#L5IHCV53 https://eprint.iacr.org/2018/1049
Classic https://iohk.io/research/papers/#9BKRHCSI https://eprint.iacr.org/2016/889
Praos https://iohk.io/research/papers/#XJ6MHFXX and (superseded by?) https://iohk.io/research/papers/#AQZE2XCV https://eprint.iacr.org/2017/573 and (superseded by?) https://eprint.iacr.org/2018/378

Also, Permissive BFT: https://hydra.iohk.io/job/Cardano/cardano-ledger-specs/byronChainSpec/latest/download-by-type/doc-pdf/blockchain-spec

Some context: Byron implements Classic and Shelley implements Praos with BFT to be used during the transition. Thoos comes after Praos, but we're not there yet.

@edsko edsko changed the title Protocol testing: test chain quality Test chain quality Jan 6, 2020
@dnadales dnadales transferred this issue from IntersectMBO/ouroboros-network Dec 1, 2023
@dnadales dnadales added the better-tests Ideas to improve the tests label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
better-tests Ideas to improve the tests
Projects
None yet
Development

No branches or pull requests

4 participants