You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When debugging IntersectMBO/ouroboros-network#1779, we were confused for a moment because the shrinker was masking the real error. After shrinking (i.e. what we initially saw), the error was a property failure: all transactions were rejected with MissingInput. We eventually realized that before shrinking, the failure was an error exception due to an Invalid initial transaction, which itself was caused by the hash collision.
This Issue is to refine the shrinker so that it does not introduce failures. Specifically, it should either not make changes that make previously-valid transactions invalid or it should remove them/update their expectation flag/etc when it invalidates them.
It may be that the rather insidious circumstance of a hash collision was causing that particular misbehavior. In that case, it might be fine to summarize in this Issue why more usual circumstances won't cause the shrinker to misbehave and then close Issue.
The text was updated successfully, but these errors were encountered:
dnadales
transferred this issue from IntersectMBO/ouroboros-network
Dec 1, 2023
When debugging IntersectMBO/ouroboros-network#1779, we were confused for a moment because the shrinker was masking the real error. After shrinking (i.e. what we initially saw), the error was a property failure: all transactions were rejected with
MissingInput
. We eventually realized that before shrinking, the failure was anerror
exception due to anInvalid initial transaction
, which itself was caused by the hash collision.This Issue is to refine the shrinker so that it does not introduce failures. Specifically, it should either not make changes that make previously-valid transactions invalid or it should remove them/update their expectation flag/etc when it invalidates them.
It may be that the rather insidious circumstance of a hash collision was causing that particular misbehavior. In that case, it might be fine to summarize in this Issue why more usual circumstances won't cause the shrinker to misbehave and then close Issue.
The text was updated successfully, but these errors were encountered: