Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply clock changes to running nodes in the consensus tests #675

Open
edsko opened this issue Feb 4, 2020 · 2 comments
Open

Apply clock changes to running nodes in the consensus tests #675

edsko opened this issue Feb 4, 2020 · 2 comments
Assignees
Labels
better-tests Ideas to improve the tests

Comments

@edsko
Copy link
Contributor

edsko commented Feb 4, 2020

As part of IntersectMBO/ouroboros-network#759 (PR IntersectMBO/ouroboros-network#1554) we introduced tests for the BlockchainTime in the presence of an unstable clock. However, it would be good to extend also the consensus tests to apply clock changes, to catch stuff like IntersectMBO/ouroboros-network#1570 and IntersectMBO/ouroboros-network#1544 (comment) .

@nfrisby
Copy link
Contributor

nfrisby commented Feb 6, 2020

Thomas and I think that Issue #753 is essentially blocking this: letting the nodes' clocks jump independently will effectively introduce clock skew.

Letting the nodes' clocks all jump together, remaining in sync, seems less interesting, but it would almost certainly be easier to test.

@edsko
Copy link
Contributor Author

edsko commented Feb 7, 2020

Unless UTCTime is reset, that doesn't seem particularly useful to test 😁

@nfrisby nfrisby transferred this issue from IntersectMBO/ouroboros-network Nov 30, 2023
@nfrisby nfrisby added the better-tests Ideas to improve the tests label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
better-tests Ideas to improve the tests
Projects
None yet
Development

No branches or pull requests

2 participants