From 941e43638be6ad6ea0b87a6161f231f3b6efa02d Mon Sep 17 00:00:00 2001 From: niraj Date: Wed, 10 Jul 2024 15:55:56 +0545 Subject: [PATCH 1/4] fix: verify identity on navigation to proposal creation for treasury proposal draft --- .../7-proposal-submission/proposalSubmission.loggedin.spec.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/govtool-frontend/playwright/tests/7-proposal-submission/proposalSubmission.loggedin.spec.ts b/tests/govtool-frontend/playwright/tests/7-proposal-submission/proposalSubmission.loggedin.spec.ts index d057e7601..2ab818007 100644 --- a/tests/govtool-frontend/playwright/tests/7-proposal-submission/proposalSubmission.loggedin.spec.ts +++ b/tests/govtool-frontend/playwright/tests/7-proposal-submission/proposalSubmission.loggedin.spec.ts @@ -375,7 +375,8 @@ test.describe("Temporary proposal users", () => { test.beforeEach(async () => { proposalSubmissionPage = new ProposalSubmissionPage(userPage); - await proposalSubmissionPage.goto(); + await proposalSubmissionPage.proposalCreateBtn.click(); + await proposalSubmissionPage.continueBtn.click(); await proposalSubmissionPage.addLinkBtn.click(); proposalFormValue = From 52755077a3329ff229b4dc76b864bb3e3e856fae Mon Sep 17 00:00:00 2001 From: niraj Date: Wed, 10 Jul 2024 18:46:58 +0545 Subject: [PATCH 2/4] chore: add assertion instead of wait timeout on get and view draft --- .../lib/pages/proposalSubmissionPage.ts | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/tests/govtool-frontend/playwright/lib/pages/proposalSubmissionPage.ts b/tests/govtool-frontend/playwright/lib/pages/proposalSubmissionPage.ts index 103675b4e..9334f8ae9 100644 --- a/tests/govtool-frontend/playwright/lib/pages/proposalSubmissionPage.ts +++ b/tests/govtool-frontend/playwright/lib/pages/proposalSubmissionPage.ts @@ -150,21 +150,30 @@ export default class ProposalSubmissionPage { } async getAllDrafts() { - await this.page.waitForTimeout(2_000); // wait until draft is loaded + await expect( + this.page.locator('[data-testid^="draft-"][data-testid$="-card"]') + ).toBeVisible(); + return await this.page .locator('[data-testid^="draft-"][data-testid$="-card"]') .all(); } async getFirstDraft() { - await this.page.waitForTimeout(2_000); // wait until draft is loaded + await expect( + this.page.locator('[data-testid^="draft-"][data-testid$="-card"]') + ).toBeVisible(); + return this.page .locator('[data-testid^="draft-"][data-testid$="-card"]') .first(); } async viewFirstDraft() { - await this.page.waitForTimeout(2_000); // wait until draft is loaded + await expect( + this.page.locator('[data-testid^="draft-"][data-testid$="-card"]') + ).toBeVisible(); + return await this.page .locator('[data-testid^="draft-"][data-testid$="-start-editing"]') .first() From 59277c7fbcc2a9d86b33959acac0c12b65bd2528 Mon Sep 17 00:00:00 2001 From: niraj Date: Thu, 18 Jul 2024 12:19:18 +0545 Subject: [PATCH 3/4] fix: proposal created with poll enabled test issue due to user auth and wallet --- .../proposalDiscussion.loggedin.spec.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/govtool-frontend/playwright/tests/8-proposal-discussion/proposalDiscussion.loggedin.spec.ts b/tests/govtool-frontend/playwright/tests/8-proposal-discussion/proposalDiscussion.loggedin.spec.ts index 5eda4f35d..badc38fad 100644 --- a/tests/govtool-frontend/playwright/tests/8-proposal-discussion/proposalDiscussion.loggedin.spec.ts +++ b/tests/govtool-frontend/playwright/tests/8-proposal-discussion/proposalDiscussion.loggedin.spec.ts @@ -73,8 +73,8 @@ test.describe("Proposal created logged in state", () => { test.describe("Proposal created with poll enabled (user auth)", () => { test.use({ - storageState: ".auth/user01.json", - wallet: user01Wallet, + storageState: ".auth/proposal02.json", + wallet: proposal02Wallet, pollEnabled: true, }); @@ -84,8 +84,6 @@ test.describe("Proposal created with poll enabled (user auth)", () => { proposalDiscussionDetailsPage = new ProposalDiscussionDetailsPage(page); await proposalDiscussionDetailsPage.goto(proposalId); await proposalDiscussionDetailsPage.verifyIdentityBtn.click(); - - await proposalDiscussionDetailsPage.closeUsernamePrompt(); }); test("8Q. Should vote on poll.", async ({ page }) => { From 67dd138a7f876fb4d915b58e0100d5b0fbfcb4f3 Mon Sep 17 00:00:00 2001 From: niraj Date: Mon, 22 Jul 2024 12:26:25 +0545 Subject: [PATCH 4/4] chore: increase get draft assertion timeout due to slow rendering --- .../playwright/lib/pages/proposalSubmissionPage.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/govtool-frontend/playwright/lib/pages/proposalSubmissionPage.ts b/tests/govtool-frontend/playwright/lib/pages/proposalSubmissionPage.ts index 9334f8ae9..9113279c1 100644 --- a/tests/govtool-frontend/playwright/lib/pages/proposalSubmissionPage.ts +++ b/tests/govtool-frontend/playwright/lib/pages/proposalSubmissionPage.ts @@ -152,7 +152,7 @@ export default class ProposalSubmissionPage { async getAllDrafts() { await expect( this.page.locator('[data-testid^="draft-"][data-testid$="-card"]') - ).toBeVisible(); + ).toBeVisible({ timeout: 10_000 }); // slow rendering return await this.page .locator('[data-testid^="draft-"][data-testid$="-card"]') @@ -162,7 +162,7 @@ export default class ProposalSubmissionPage { async getFirstDraft() { await expect( this.page.locator('[data-testid^="draft-"][data-testid$="-card"]') - ).toBeVisible(); + ).toBeVisible({ timeout: 10_000 }); // slow rendering return this.page .locator('[data-testid^="draft-"][data-testid$="-card"]') @@ -172,7 +172,7 @@ export default class ProposalSubmissionPage { async viewFirstDraft() { await expect( this.page.locator('[data-testid^="draft-"][data-testid$="-card"]') - ).toBeVisible(); + ).toBeVisible({ timeout: 10_000 }); // slow rendering return await this.page .locator('[data-testid^="draft-"][data-testid$="-start-editing"]')