Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Validation Issue: Empty Username Incorrectly Accepted Despite Error Message #1535

Closed
kneerose opened this issue Jul 9, 2024 · 8 comments
Assignees
Labels
🐛 Bug Something isn't working PDF Bug

Comments

@kneerose
Copy link
Contributor

kneerose commented Jul 9, 2024

Context & versions

  • According to the error message, an empty username should not be accepted, but it currently is.

image

Steps to reproduce

  • Connect to the wallet with the username not set.
  • Navigate to the proposal page and verify the identity.
  • Observe the proceed with this username button it is enabled and can perform the action

Actual behaviour

  • The "Proceed with this username" button is enabled even with an empty username.

image

  • As an empty username is already taken, an error message is displayed like this:

image

Expected behaviour

  • The "Proceed with this username" button should be disabled for an empty username according to the error message: Username must be between 1 and 30 characters and cannot start with a period or underscore.
  • The platform should not accept an empty username.
@vpaunovic
Copy link

@kneerose It can be tested on dev with new version of pdf now.

CC: @bosko-m

@kneerose
Copy link
Contributor Author

@vpaunovic, I have tested it on dev. I see that the above issue is fixed, but the invalid username is still acceptable. The 'Proceed with this username' button is visible for an invalid username.

image

@vpaunovic
Copy link

@kneerose okay, thanks. @teske00 Can you cheak this?

@vpaunovic
Copy link

@kneerose It's fixed. When it was pushed somehow one condition was missed for disabling that button, as it was in input condition. It will be pushed to a new version and when it is available with that new package version it will be available for dev test.

@kneerose
Copy link
Contributor Author

@vpaunovic I see the changes on the dev environment but not yet on the test environment. The ticket will be closed once the changes are available in the test environment.
CC: @bosko-m

@bosko-m
Copy link
Contributor

bosko-m commented Jul 23, 2024

Please dont close it after it passes the testing on test environment @kneerose . Intersect should give in this case final sign off after testing it on staging.

@kneerose
Copy link
Contributor Author

kneerose commented Aug 8, 2024

I've reviewed the changes on the test environment.
This issue can be closed now. CC: @bosko-m

@bosko-m
Copy link
Contributor

bosko-m commented Aug 8, 2024

CLosing as per the comment above.

@bosko-m bosko-m closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working PDF Bug
Projects
Status: Done
Development

No branches or pull requests

4 participants