Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Governance Action Proposal Submission Metadata Anchor Validation #1476

Closed
kneerose opened this issue Jul 5, 2024 · 10 comments
Closed
Assignees
Labels
🐛 Bug Something isn't working PDF Bug

Comments

@kneerose
Copy link
Contributor

kneerose commented Jul 5, 2024

Context & versions

  • This issue is related to [BUG] Metadata anchor validation #1180
  • The proposal submission metadata URL field allows users to enter URLs exceeding the expected character limit (greater than 128 bytes) and does not display any error message if the URL is invalid.
  • For reference look into the dRep Registration metadata anchor validation

Steps to reproduce

  • Navigate to created proposal details.
  • Submit it as a governance action.
  • In the metadata anchor field, enter a URL that
    • Exceeds 128 bytes
    • Is an Invalid URL.
  • Observe that the submit button remains enabled and no error message is displayed.

Actual behaviour

  • No error message is shown, and the submit button is enabled despite the URL exceeding the character limit and being invalid.

Screenshot from 2024-07-05 11-46-02

image

Expected behaviour

  • An appropriate error message should be displayed to clearly inform the user when:
    • The URL exceeds 128 bytes.
    • The URL is invalid.
  • The submit button should be disabled until a valid URL is entered.

Screenshot from 2024-07-05 11-44-43

image

Report Reference

@kneerose kneerose changed the title [BUG] Proposal submission Metadata Anchor validation [BUG] Governance Action Proposal Submission Metadata Anchor Validation Jul 5, 2024
@kneerose kneerose added 🐛 Bug Something isn't working PDF Bug labels Jul 5, 2024
@teske00
Copy link

teske00 commented Jul 8, 2024

@kneerose It is deployed on dev, it can be tested

@kneerose
Copy link
Contributor Author

kneerose commented Jul 9, 2024

I have reviewed your changes, but it seems you missed adding test IDs for the new components. Please ensure that you include proper test IDs for any new components in the future.

image
image

@vpaunovic
Copy link

@kneerose It can be tested on dev with new version of pdf now.

CC: @bosko-m

@kneerose
Copy link
Contributor Author

@vpaunovic

The "Required" message is always visible. Is it intended to be always visible? Currently, the test ID used for "Required" is the same as that for "Invalid URL" and "URL must be less than 128 bytes." This will conflict with our test. If the "Required" message is intended always to be shown, please use a different test ID for each message.

image

@vpaunovic
Copy link

@kneerose It is required. It is helper text, not an error. The error is red color and red border around input.. so.. i will put different testid string in case if it is error or just helper text.And we will put it in new pdf package version! 😀

cc: @teske00

@vpaunovic
Copy link

@kneerose It is fixed and it will be available in new pdf package version and when it is deployed on dev. It will have required-url-input-text data-testid when there is no error and just Required text as helperText.

CC: @teske00

@kneerose
Copy link
Contributor Author

@vpaunovic I see the changes on the dev environment but not yet on the test environment . The ticket will be closed once the changes are available in the test environment.
CC: @bosko-m

@bosko-m
Copy link
Contributor

bosko-m commented Jul 23, 2024

Please dont close it after it passes the testing on test environment @kneerose . Intersect should give in this case final sign off after testing it on staging.

@kneerose
Copy link
Contributor Author

kneerose commented Aug 8, 2024

I've reviewed the changes on the test environment.
This issue can be closed now.
CC: @bosko-m

@bosko-m
Copy link
Contributor

bosko-m commented Aug 8, 2024

Closing as per the comment above.

@bosko-m bosko-m closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working PDF Bug
Projects
Status: Done
Development

No branches or pull requests

4 participants