Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export fromShelleyBasedScript from Cardano.Api, backported to 1.35 #4681

Closed
wants to merge 1 commit into from
Closed

Export fromShelleyBasedScript from Cardano.Api, backported to 1.35 #4681

wants to merge 1 commit into from

Conversation

eyeinsky
Copy link
Contributor

Backported to release/1.35, original here #4386

JaredCorduan
JaredCorduan approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Jimbo4350
Jimbo4350 approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please check with Sam if there is anything else you need to do before merging this.

@eyeinsky
Copy link
Contributor Author

eyeinsky commented Jan 20, 2023 •
edited
Loading

We've disabled the test that depended on this fix and will enable it again when when we depend on a new release of cardano-node.

This was the wrong PR, but closing this as well, as new changes should be made on master.

@eyeinsky eyeinsky closed this Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eyeinsky @JaredCorduan @Jimbo4350