Handle pipes

[LudvikGalois]

Fixes #4235

[Jimbo4350]

Sorry, I'm a bit confused. How does this work?

[LudvikGalois]

Sorry, I'm a bit confused. How does this work?

In the normal course of operation, we sometimes read files multiple times. This is somewhat unexpected for a user, and doesn't work if the file isn't a real file, but a pipe, since after the contents have been read there's nothing to left to read.
FileOrPipe is a reference to a file-like thing. readFileOrPipe reads the file into memory (this is not ideal, but otherwise we have to deal with lazy IO, which can be a headache and in general these are small files) and once it's done checks if the file is a pipe or not. If it's a pipe, it saves the contents in an IORef so that will be used on subsequent reading attempts, otherwise it throws it away.
What changes is that some functions which used to take filenames, now take FileOrPipes and readFileOrPipe is used instead of readFile.

[Jimbo4350]

Sorry, I'm a bit confused. How does this work?

In the normal course of operation, we sometimes read files multiple times. This is somewhat unexpected for a user, and doesn't work if the file isn't a real file, but a pipe, since after the contents have been read there's nothing to left to read. FileOrPipe is a reference to a file-like thing. readFileOrPipe reads the file into memory (this is not ideal, but otherwise we have to deal with lazy IO, which can be a headache and in general these are small files) and once it's done checks if the file is a pipe or not. If it's a pipe, it saves the contents in an IORef so that will be used on subsequent reading attempts, otherwise it throws it away. What changes is that some functions which used to take filenames, now take FileOrPipes and readFileOrPipe is used instead of readFile.

Thanks for the explanation. Can you add a summary as a comment on top of readFileOrPipe? Happy to approve once the other comments are addressed. We also need @saratomaz to confirm this fix is working.

[saratomaz]

Solved

txFileJSON=$(cat <<-EOF
{
  "type": "Unwitnessed Tx BabbageEra",
  "description": "Ledger Cddl Format",
  "cborHex": "84a300818258208a5a31ae52cdc140b1c532c47d5cb3c8dbc6c9b7a4aa537ed9e3543ea94cfad1000183a200581d60768d2bcd29a84ae015d96118e3285bc0cbd399ae16039ad471c8a806011a001e8480a200581d60768d2bcd29a84ae015d96118e3285bc0cbd399ae16039ad471c8a806011a002625a0a200581d600ac4d3db1163e7884959c0317aa19263a236db113fa0fbefbd49b335011a00958d31021a0003094fa0f5f6"
}
EOF
)

cardano-cli transaction txid --tx-file <(echo "${txFileJSON}")
a2e58d1b59d8c06535a1134f0022b1c77b5dc679248f635197546b6855830730

[soltanoff]

Hi, @LudvikGalois, @saratomaz

What about the status of this PR? I need it very much.

Thank you!

[soltanoff]

@erikd, @Jimbo4350 jFYI.

[LudvikGalois]

Hi, @LudvikGalois, @saratomaz

What about the status of this PR? I need it very much.

Thank you!

I no longer work at IOG, and @Jimbo4350 (who this has likely passed to) is probably drowning in work, so this may not be addressed immediately.

However, it is almost "ready to merge". After a rebase, everything apart from the test should be fine. As for the test, the current incarnation of the test doesn't actually need a testnet, so it should move from the testnet project back into the CLI. It also needs some tweaking so it'll compile under windows (it currently fails to compile on Windows due to unused imports, because the test itself does some unix specific things, so the windows implementation of the test is a stub which is then skipped).

[Jimbo4350]

Hi, @LudvikGalois, @saratomaz

What about the status of this PR? I need it very much.

Thank you!

I'm working on this to get it merged this week.

[soltanoff]

@LudvikGalois, oh, I got it. Thank you for information.

@Jimbo4350, I’ll waiting for it, thanks a lot 🙏.

[saratomaz]

@Jimbo4350 let me know if you want me to test it again

[newhoggy]

bors r+

[iohk-bors]

Build failed:

• ci/pr/required

[newhoggy]

bors r+

[iohk-bors]

Timed out.

[newhoggy]

bors r+

[iohk-bors]

Timed out.

[Jimbo4350]

bors r+

[iohk-bors]

This PR was included in a batch that timed out, it will be automatically retried

[iohk-bors]

This PR was included in a batch that timed out, it will be automatically retried

[iohk-bors]

Canceled.

[newhoggy]

bors r+

[iohk-bors]

Build succeeded:

• check-cabal-files
• ci/pr/required