-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore --cddl-format #4617
Merged
iohk-bors
merged 2 commits into
release/1.35
from
newhoggy/restore-cddl-format-as-hidden-deprecated-option
Nov 5, 2022
Merged
Restore --cddl-format #4617
iohk-bors
merged 2 commits into
release/1.35
from
newhoggy/restore-cddl-format-as-hidden-deprecated-option
Nov 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
changed the title
Restore --cddl-format as a hidden switch to avoid breaking 3rd party …
Restore --cddl-format
Nov 4, 2022
newhoggy
requested review from
dcoutts,
Jimbo4350,
erikd and
JaredCorduan
as code owners
November 4, 2022 13:53
Jimbo4350
approved these changes
Nov 4, 2022
newhoggy
force-pushed
the
newhoggy/restore-cddl-format-as-hidden-deprecated-option
branch
from
November 4, 2022 13:56
bb00609
to
97ddcfa
Compare
…tooling. The restore switch has no effect Add --cddl-format flag to tests to confirm backwards compatibility
Jimbo4350
force-pushed
the
newhoggy/restore-cddl-format-as-hidden-deprecated-option
branch
from
November 4, 2022 15:35
97ddcfa
to
97865a5
Compare
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 5, 2022
4617: Restore --cddl-format r=disassembler a=newhoggy as a hidden switch to avoid breaking 3rd party tooling. The restore switch has no effect Resolves #4597 Co-authored-by: John Ky <[email protected]>
Timed out. |
Looks good, the |
bors r+ |
Build succeeded: |
iohk-bors
bot
deleted the
newhoggy/restore-cddl-format-as-hidden-deprecated-option
branch
November 5, 2022 09:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a hidden switch to avoid breaking 3rd party tooling. The restore switch has no effect
Resolves #4597