Expose module Cardano.Api.Script from cardano-api #4386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyeinsky
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy and
JaredCorduan
as code owners
|
I would suggest to not expose this hidden module. Instead, add the function you want to export in the |
eyeinsky
force-pushed
the
export-cardano-api-script
branch
from
3243a0e to
6195c6b
Compare
eyeinsky
force-pushed
the
export-cardano-api-script
branch
from
6195c6b to
8679461
Compare
|
@Jimbo4350 done! |
|
@Jimbo4350 Does this PR look good now? Here is the code we could get rid of and stop maintaining, if this is merged. :) |
eyeinsky
force-pushed
the
export-cardano-api-script
branch
from
8679461 to
db7b1d9
Compare
eyeinsky
requested review from
LudvikGalois and
CarlosLopezDeLara
as code owners
eyeinsky
force-pushed
the
export-cardano-api-script
branch
2 times, most recently
from
f537336 to
3d4cc9b
Compare
eyeinsky
force-pushed
the
export-cardano-api-script
branch
from
3d4cc9b to
6866da0
Compare
This was referenced Nov 29, 2022
|
Closing this in favor of the new PR here #4682 |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 28, 2023
4625: Handle pipes r=Jimbo4350 a=LudvikGalois Fixes #4235 4682: Export `fromShelleyBasedScript` from Cardano.Api r=Jimbo4350 a=eyeinsky New PR based off of a branch in this repo. Old PR here #4386 Co-authored-by: Robert 'Probie' Offner <[email protected]> Co-authored-by: Markus Läll <[email protected]>
iohk-bors bot
added a commit
that referenced
this pull request
Feb 28, 2023
4682: Export `fromShelleyBasedScript` from Cardano.Api r=Jimbo4350 a=eyeinsky New PR based off of a branch in this repo. Old PR here #4386 Co-authored-by: Markus Läll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm writing an indexer for the blockchain from script hash to script IntersectMBO/plutus-apps#629 and would like to use the conversion functions from ledger to cardano-api scripts in Cardano.Api.Script, would it be ok to export the module?