Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing is costly #608

Closed
deepfire opened this issue Feb 27, 2020 · 4 comments
Closed

Tracing is costly #608

deepfire opened this issue Feb 27, 2020 · 4 comments

Comments

@deepfire
Copy link
Contributor

deepfire commented Feb 27, 2020

@mrBliss reports a relatively high cost incurred by logging.

Description of his setup:

  1. chain syncing between two local processes:

    one fully-synced "server" node (nothing to do but serve blocks) and one empty "client" node (nothing to do but download blocks)

  2. log configuration from configuration/configuration-mainnet.yaml
  3. two cases:
    • normal cardano-node, 50k blocks in 1 minute
    • cardano-node with all tracers set to nullTracer: 75k blocks in 1 minute
@deepfire
Copy link
Contributor Author

@mrBliss, @dcoutts, how do you propose we should account for the non-framework costs of forcing the lazily-evaluated thunks of the traces?

It's pretty obvious that profiling needs to be done before any conclusions can be made, though..

@mrBliss
Copy link
Contributor

mrBliss commented Feb 28, 2020

@mrBliss, @dcoutts, how do you propose we should account for the non-framework costs of forcing the lazily-evaluated thunks of the traces?

It's pretty obvious that profiling needs to be done before any conclusions can be made, though..

Most of the things that are being traced are already evaluated to (almost) normal form, at least on consensus side. Related: IntersectMBO/ouroboros-network#1386

@CodiePP
Copy link
Contributor

CodiePP commented Feb 28, 2020

this PR #494 defines the set of tracers which are on per default.
the amount of logged information can be controlled by either turning on/off a tracer and setting the minSeverity filter.

@CarlosLopezDeLara
Copy link
Contributor

This issue should have been closed after IntersectMBO/ouroboros-network#1386 and IntersectMBO/ouroboros-consensus#739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants