Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - TextEnvelopeCddl error when assembling Shelley-era Tx body in CDDL format #4493

Closed
mkoura opened this issue Sep 29, 2022 · 0 comments · Fixed by #4501
Closed

[BUG] - TextEnvelopeCddl error when assembling Shelley-era Tx body in CDDL format #4493

mkoura opened this issue Sep 29, 2022 · 0 comments · Fixed by #4501
Labels
bug Something isn't working comp: cardano-cli type: regression A feature that worked before stoped working user type: internal Created by an IOG employee

Comments

@mkoura
Copy link
Contributor

mkoura commented Sep 29, 2022

Internal

Area
Other Any other topic (Delegation, Ranking, ...).

Summary
Assembling Shelley-era Tx body in CDDL format with witnesses fails with TextEnvelopeCddl error:

cardano-cli transaction assemble --tx-body-file test_normal_tx_from_script_addr_ci0_dll_False_to_tx.body --out-file test_normal_tx_from_script_addr_ci0_dll_False_to_tx.witnessed --witness-file test_normal_tx_from_script_addr_ci0_dll_False_to_skey0_tx.witness

Command failed: transaction sign-witness Error: Failed to decode neither the cli's serialisation format nor the ledger's CDDL serialisation format. TextEnvelope error: test_normal_tx_from_script_addr_ci0_dll_False_to_skey0_tx.witness: TextEnvelope type error: Expected one of: TxWitnessByron, TxWitnessShelley, TxWitness AllegraEra, TxWitness MaryEra, TxWitness AlonzoEra, TxWitness BabbageEra Actual: TxWitness ShelleyEra
TextEnvelopeCddl error: test_normal_tx_from_script_addr_ci0_dll_False_to_skey0_tx.witness: TextEnvelopeCddl type error: Expected one of: Actual: TxWitness ShelleyEra

Steps to reproduce
Steps to reproduce the behavior:

  1. Create Shelley-ear Tx body in CDDL format
  2. Try to asseble the Tx body and witnesses to form a transaction
  3. See error

Expected behavior
A Shelley-era Tx can be assembled from body in CDDL format.

System info:

@mkoura mkoura added the bug Something isn't working label Sep 29, 2022
iohk-bors bot added a commit that referenced this issue Oct 5, 2022
4501: Fix 4493 bug r=Jimbo4350 a=Jimbo4350

Resolves: #4493 

Co-authored-by: Jordan Millar <[email protected]>
@iohk-bors iohk-bors bot closed this as completed in 76beb9a Oct 5, 2022
Jimbo4350 added a commit that referenced this issue Oct 5, 2022
Fix 4493 bug - essentially the type field in the Shelley era text envelope tx body was being written to disk as "TxWitnessShelley" and being read from disk as "TxWitness Shelley". I.e there was a mismatch and therefore it was not possible to read shelley era transaction bodies.

Closes: #4493
@dorin100 dorin100 added type: regression A feature that worked before stoped working user type: internal Created by an IOG employee comp: cardano-cli labels Oct 21, 2022
disassembler pushed a commit that referenced this issue Oct 25, 2022
Fix 4493 bug - essentially the type field in the Shelley era text envelope tx body was being written to disk as "TxWitnessShelley" and being read from disk as "TxWitness Shelley". I.e there was a mismatch and therefore it was not possible to read shelley era transaction bodies.

Closes: #4493
newhoggy pushed a commit to IntersectMBO/cardano-api that referenced this issue May 23, 2023
Fix 4493 bug - essentially the type field in the Shelley era text envelope tx body was being written to disk as "TxWitnessShelley" and being read from disk as "TxWitness Shelley". I.e there was a mismatch and therefore it was not possible to read shelley era transaction bodies.

Closes: IntersectMBO/cardano-node#4493
newhoggy pushed a commit to IntersectMBO/cardano-cli that referenced this issue May 24, 2023
Fix 4493 bug - essentially the type field in the Shelley era text envelope tx body was being written to disk as "TxWitnessShelley" and being read from disk as "TxWitness Shelley". I.e there was a mismatch and therefore it was not possible to read shelley era transaction bodies.

Closes: IntersectMBO/cardano-node#4493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working comp: cardano-cli type: regression A feature that worked before stoped working user type: internal Created by an IOG employee
Projects
None yet
2 participants