Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] - executeLocalStateQueryExpr allow tx submission, short-term solution #4358

Open
Tracked by #4144
cleverca22 opened this issue Aug 18, 2022 · 1 comment
Open
Tracked by #4144
Labels
comp: cardano-api enhancement New feature or request type: enhancement An improvement on the existing functionality user type: external Created by an external user

Comments

@cleverca22
Copy link
Contributor

cleverca22 commented Aug 18, 2022

Internal

Describe the feature you'd like
executeLocalStateQueryExpr currently sets localTxSubmissionClient = Nothing so there is no way to submit transactions over the same connection as the state query monad

the short-term solution i can see, is to just expose the 2 Maybe's for localTxSubmissionClient and localTxMonitoringClient, and just make those into arguments for executeLocalStateQueryExpr
the call-site can then either Nothing Nothing those args to maintain the old behaviour, or they can Just submissionClient to supply a client

the long-term solution i can see, is for the localTxSubmissionClient to also support a monad based interface, like how executeLocalStateQueryExpr adds tolocalStateQueryClient: #4357

@cleverca22 cleverca22 added the enhancement New feature or request label Aug 18, 2022
@CarlosLopezDeLara CarlosLopezDeLara moved this to 📋 Backlog in Node CLI/API 2022 Aug 19, 2022
@CarlosLopezDeLara
Copy link
Contributor

@dorin100 dorin100 added type: enhancement An improvement on the existing functionality user type: external Created by an external user comp: cardano-api labels Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: cardano-api enhancement New feature or request type: enhancement An improvement on the existing functionality user type: external Created by an external user
Projects
None yet
Development

No branches or pull requests

3 participants