Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge the code base of the RequireNetworkMagic type #312

Closed
erikd opened this issue Nov 20, 2019 · 3 comments
Closed

Purge the code base of the RequireNetworkMagic type #312

erikd opened this issue Nov 20, 2019 · 3 comments
Milestone

Comments

@erikd
Copy link
Contributor

erikd commented Nov 20, 2019

This type is defined in cardano-config/src/Cardano/Config/Types.hs as:

data RequireNetworkMagic
    = RequireNetworkMagic
    | NoRequireNetworkMagic
    deriving (Eq, Show)

but is close to identical to this from cardano-ledger:

data RequiresNetworkMagic
  = RequiresNoMagic
  | RequiresMagic
  deriving (Show, Eq, Generic, NFData, NoUnexpectedThunks)

Its a huge pain in the neck have two type that are completely isomorphic.

RequireNetworkMagic has to die and be replaced by the one from ledger

@erikd
Copy link
Contributor Author

erikd commented Nov 20, 2019

Probably also worth checking if there are any other types like this that mirror types lower in the dependency stack and kill them at the same time.

@erikd
Copy link
Contributor Author

erikd commented Nov 20, 2019

Not a priority for this weeks' snapshot but should do it early next week.

@Jimbo4350
Copy link
Contributor

Removed in #326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants