-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0031 Reference Inputs #993
Comments
We should also have a test that runs a plutus script validating that it has visbility of referenced outputs, see reference inputs |
This comment was marked as duplicate.
This comment was marked as duplicate.
@dorin100 for AC2 - can we also make sure that 2 different transactions can fetch the same reference input in the same block? |
@dorin100 can we please add an AC to create a reference input? Also, test the UTxO deposit and what happens with the native tokens - if all works as expected. Also, please add another AC to check if the cost provided by the CLI for storing and TX fee is accurate. And finally, a new AC to test if a user can destroy a reference input and recover the storage deposit back. Thanks! |
@dorin100 how can we test the following? This ACs shall apply to all CIPs, shall we add to each one of is enough to add to one of the CIPs ACs? Thanks
|
I think any new input can be referenced so in that case this would be covered |
this should be simple regression as here there will not be any new functionality; if that is the case, we already have automated tests for this |
My understanding is that Reference Input is a special type of input. Can you please double-check? From CDDL I can see: |
good point; |
I feel I don't understand this; IMO an input can be consumed/spent and in that case, it will not be available anymore (to be referenced) I am not aware of any new type of deposit --> do you have more details about this, maybe I missed something...? |
I will add this to any thicket as there will be different cli commands. thank you |
Destroy is not the correct nomenclature. Basically, the AC is the following: Given I am a dapp developer Can you please add such an AC to all CIPs, please? Since all will share the same mechanism. Thank you! |
My understanding is that when you don't need the reference input anymore, you consume/spend it and that is all (I am not aware of any storage deposit and I don't remember reading about it anywhere). Based on what did you create this expectation? LE: we discussed this online - it was about the minUtxoValue --> I added some checks to AC2 here - #995 |
This tells me that inputs and reference inputs are both the same type, a set of transaction ids and indices. |
@dorin100 can we add: It shall be possible to review a reference input using the transaction view command - please |
cardano-node related PR:
#3810
cardano-node bugs
4073 -> Improve build behaviour of build with invalid reference inputs #1343
4012 -> Improve message #1344
info
https://github.com/cardano-foundation/CIPs/tree/master/CIP-0031
AC1 Possible to reference a transaction input allowing looking at it without spending it
AC2 Outputs can be referenced multiple times, so we have non-interference even under heavy usage of referencing.
AC3 Scripts with old versions cannot be spent in transactions that include reference inputs, attempting to do so will be a phase 1 transaction validation failure.
AC4 A transaction must always spend at least one UTXO, and UTXOs can only be spent once.
AC5 Spending conditions on referenced outputs are not checked
AC6 Plutus can see everything available in an Alonzo tx: value, tokens, datum hash - Plutus script required
Plutus v2 tests with dedicated plutus scripts #1261
AC7 the new cost model is respected
AC8 new CLI commands/parameters
The text was updated successfully, but these errors were encountered: