Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check ppuCoinsPerUTxOBytes well-formedness #4650

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Check ppuCoinsPerUTxOBytes well-formedness #4650

merged 1 commit into from
Sep 30, 2024

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Sep 28, 2024 •
edited
Loading

Description

Resolves #4631

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Lucsanszky Lucsanszky force-pushed the ldan/ppcoinsperutxobyte branch from f79a24f to e351395 Compare September 29, 2024 15:51
@Lucsanszky Lucsanszky marked this pull request as ready for review September 29, 2024 15:51
@Lucsanszky Lucsanszky requested a review from a team as a code owner September 29, 2024 15:51
@Lucsanszky Lucsanszky force-pushed the ldan/ppcoinsperutxobyte branch from e351395 to 1b7b29e Compare September 29, 2024 20:01
@Lucsanszky Lucsanszky force-pushed the ldan/ppcoinsperutxobyte branch from 1b7b29e to fdefe00 Compare September 29, 2024 20:09
Soupstraw
Soupstraw approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lucsanszky Lucsanszky merged commit fe4c1be into master Sep 30, 2024
155 checks passed
@Lucsanszky Lucsanszky deleted the ldan/ppcoinsperutxobyte branch September 30, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins left review comments

@Soupstraw Soupstraw Soupstraw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ppCoinsPerUTxOByte to ppWellFormed
3 participants
@Lucsanszky @lehins @Soupstraw