Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow empty TreasuryWithdrawals #4630

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Disallow empty TreasuryWithdrawals #4630

merged 4 commits into from
Sep 24, 2024

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Sep 16, 2024 •
edited
Loading

Description

  • Disallow empty treasury withdrawals, closes: Disallow empty treasury withdrawals #4582
  • Add some tests concerning withdrawals from accounts delegated to expired or unregistered Dreps
  • Add CERTS spec and some tests concerning withdrawals that are checked in Certs rule

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu changed the title Add withdrawal test cases for delegations unregistered and expired DReps Disallow empty withdrawals Sep 16, 2024
@teodanciu teodanciu force-pushed the td/disallow-empty-withdrawals branch from d035553 to cb6eef1 Compare September 17, 2024 16:13
@teodanciu teodanciu marked this pull request as ready for review September 18, 2024 14:24
@teodanciu teodanciu requested a review from a team as a code owner September 18, 2024 14:24
@teodanciu teodanciu force-pushed the td/disallow-empty-withdrawals branch 6 times, most recently from 094672b to 4969ae4 Compare September 19, 2024 13:17
lehins
lehins requested changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding all those extra test cases!

Looks great. Just a few suggestions

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Gov.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Gov.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/GovSpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/LedgerSpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/cardano-ledger-conway.cabal Outdated Show resolved Hide resolved
eras/conway/impl/cardano-ledger-conway.cabal Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/CertsSpec.hs Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/LedgerSpec.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/Gov.hs Outdated Show resolved Hide resolved
@teodanciu teodanciu force-pushed the td/disallow-empty-withdrawals branch 3 times, most recently from 6b5b32f to e3cd9c8 Compare September 23, 2024 11:44
lehins
lehins approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Couple of minor recommendations

eras/conway/impl/CHANGELOG.md Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/CertsSpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/GovSpec.hs Outdated Show resolved Hide resolved
@teodanciu teodanciu force-pushed the td/disallow-empty-withdrawals branch from e3cd9c8 to 731309a Compare September 24, 2024 11:24
@teodanciu teodanciu force-pushed the td/disallow-empty-withdrawals branch from 731309a to 8e7bc04 Compare September 24, 2024 11:32
@teodanciu teodanciu enabled auto-merge September 24, 2024 11:32
@teodanciu teodanciu merged commit b8eab98 into master Sep 24, 2024
152 of 154 checks passed
@teodanciu teodanciu deleted the td/disallow-empty-withdrawals branch September 24, 2024 13:50
@lehins lehins changed the title Disallow empty withdrawals Disallow empty TreasuryWithdrawals Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow empty treasury withdrawals
2 participants
@teodanciu @lehins