Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ppCoinsPerUTxOByte to ppWellFormed #4631

Closed
lehins opened this issue Sep 16, 2024 · 0 comments · Fixed by #4650
Closed

Add ppCoinsPerUTxOByte to ppWellFormed #4631

lehins opened this issue Sep 16, 2024 · 0 comments · Fixed by #4650
Assignees
@Lucsanszky
Labels
conway intra-era-hardfork A task that requires an intra-era hard fork

Comments

@lehins
Copy link
Collaborator

lehins commented Sep 16, 2024 •
edited
Loading

Looks like there was a mistake in the spec and the wrong parameter was used: IntersectMBO/formal-ledger-specifications#571

We need to add ppCoinsPerUTxOByte to ppWellFormed, but we have to add it only with the protocol version check, i.e. we can't change this behavior without a hardfork.
So, despite that guardrails script already checks that ppCoinsPerUTxOByte is not equal to 0, for consistency sake with the spec we need to also implement it on the ledger side.
@lehins lehins added conway intra-era-hardfork A task that requires an intra-era hard fork labels Sep 16, 2024
@lehins lehins mentioned this issue Sep 16, 2024
Closed
@Lucsanszky Lucsanszky self-assigned this Sep 27, 2024
@Lucsanszky Lucsanszky mentioned this issue Sep 30, 2024
Merged
9 tasks
Lucsanszky added a commit that referenced this issue Sep 30, 2024
@Lucsanszky
Merge pull request #4650 from IntersectMBO/ldan/ppcoinsperutxobyte
fe4c1be 
Check `ppuCoinsPerUTxOBytes` well-formedness

Resolves #4631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lucsanszky Lucsanszky

Labels
conway intra-era-hardfork A task that requires an intra-era hard fork
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check ppuCoinsPerUTxOBytes well-formedness IntersectMBO/cardano-ledger
2 participants
@lehins @Lucsanszky