Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cardano-api-8.44, New required flag --reference-script-size for transaction calculate-min-fee #680

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

dnadales
Copy link
Member

@dnadales dnadales commented Mar 26, 2024

Changelog

- description: |
    - New required flag `--reference-script-size` for `transaction calculate-min-fee`
    - Update cardano-api-8.44 https://github.com/IntersectMBO/cardano-api/blob/main/cardano-api/CHANGELOG.md#84400
    - Update ouroboros-consensus-0.17, ouroboros-consensus-cardano-0.15, ouroboros-consensus-protocol-0.8, cardano-ledger-shelley-1.10, cardano-ledger-byron-1.0.1

# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Requires

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

This patch also adds the reference script size to the arguments needed to calculate the transaction minimum fee.
@dnadales dnadales force-pushed the dnadales/cli-8.10 branch from 87c9b16 to 10c1b9e Compare April 4, 2024 16:46
@dnadales dnadales marked this pull request as ready for review April 4, 2024 16:46
, ouroboros-consensus-cardano >= 0.14.2
, ouroboros-consensus-protocol >= 0.7
, ouroboros-consensus >= 0.17
-- TODO: bump consensus back
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment needed?

@carbolymer carbolymer enabled auto-merge April 4, 2024 17:36
@carbolymer carbolymer changed the title CLI release for Node 8.10 Update cardano-api-8.44, New required flag --reference-script-size for transaction calculate-min-fee Apr 4, 2024
@carbolymer carbolymer changed the title Update cardano-api-8.44, New required flag --reference-script-size for transaction calculate-min-fee Update cardano-api-8.44, New required flag --reference-script-size for transaction calculate-min-fee Apr 4, 2024
@carbolymer carbolymer added this pull request to the merge queue Apr 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2024
@disassembler disassembler added this pull request to the merge queue Apr 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 4, 2024
@disassembler disassembler merged commit e4c76c7 into main Apr 4, 2024
25 of 26 checks passed
@disassembler disassembler deleted the dnadales/cli-8.10 branch April 4, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants