Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#667 Add ref-script-size query command #672

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Mar 22, 2024

Changelog

- description: |
    Add `ref-script-size` query command
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Requires:

This PR is rebased onto #680 - only #667 Add ref-script-size query command commit contains the changes related to this feature.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/feature/ref-script-size-query branch 3 times, most recently from 3292df5 to f582c37 Compare March 26, 2024 16:53
]
[--out-file FILE]

Calculate the reference input scripts size in bytes for provided transaction
Copy link
Contributor

@Jimbo4350 Jimbo4350 Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be transaction input. However we should also allow specification of txid(s) if the user has access to the reference script creation transaction
.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the text. I'll add that in the follow-up PR, is that ok?

Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, great job ❤️

@carbolymer carbolymer force-pushed the mgalazyn/feature/ref-script-size-query branch from f582c37 to 4712d7d Compare April 4, 2024 17:00
@carbolymer carbolymer marked this pull request as ready for review April 4, 2024 17:00
@carbolymer carbolymer force-pushed the mgalazyn/feature/ref-script-size-query branch from 4712d7d to 5146e2d Compare April 4, 2024 17:01
@carbolymer carbolymer force-pushed the mgalazyn/feature/ref-script-size-query branch from 5146e2d to 75779b0 Compare April 4, 2024 17:27
@disassembler disassembler enabled auto-merge April 4, 2024 17:49
@disassembler disassembler disabled auto-merge April 4, 2024 20:49
@disassembler disassembler force-pushed the mgalazyn/feature/ref-script-size-query branch from 75779b0 to cf89bcb Compare April 4, 2024 20:49
@disassembler disassembler enabled auto-merge April 4, 2024 20:49
@disassembler disassembler added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 070b8a3 Apr 4, 2024
16 checks passed
@disassembler disassembler deleted the mgalazyn/feature/ref-script-size-query branch April 4, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] - Add a command to obtain the reference script size (in bytes) of a transaction
4 participants