-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix create-testnet-data creating negative supply #599
Fix create-testnet-data creating negative supply #599
Conversation
cardano-cli/test/cardano-cli-test/Test/Cli/CreateTestnetData.hs
Outdated
Show resolved
Hide resolved
cardano-cli/test/cardano-cli-test/Test/Cli/CreateTestnetData.hs
Outdated
Show resolved
Hide resolved
|
||
-- We test that the command doesn't crash, because otherwise | ||
-- execCardanoCLI would fail. | ||
hprop_create_testnet_data_create_nonegative_supply :: Property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hprop_create_testnet_data_create_nonegative_supply :: Property | |
-- Execute this test with: | |
-- @cabal test cardano-cli-test --test-options '-p "/create testnet data create nonegative supply/"'@ | |
hprop_create_testnet_data_create_nonegative_supply :: Property |
1a99c72
to
164d8a1
Compare
d564658
to
a70fab8
Compare
@smelc thanks for pushing the commit with unique worksaces, but I finally reverted it. The reason is that it was circumventing the behaviour of our integration tests, which was saving only failed workspaces by default. After your change all the workspace were persisted which is too much information I think. Additionally I am not sure about the behaviour |
ada3394
to
fa2a785
Compare
fa2a785
to
1dfee0b
Compare
Changelog
Context
create-testnet-data
was creating negative supply which was preventing node from startChecklist