Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail: remove some dead code #560

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Detail: remove some dead code #560

merged 1 commit into from
Jan 9, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Jan 9, 2024

Changelog

- description: |
    Remove some dead code
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc marked this pull request as ready for review January 9, 2024 09:32
Copy link
Contributor

@carlhammann carlhammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also removed that (and a little bit more) here. Seems we're on the same path with this 🙂

@smelc smelc added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit 5e8ee57 Jan 9, 2024
21 checks passed
@smelc smelc deleted the smelc/removed-dead-code branch January 9, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants