Move input files out of golden directory
#454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
requested review from
a team,
Jimbo4350,
carbolymer,
kevinhammond and
disassembler
as code owners
newhoggy
force-pushed
the
newhoggy/move-input-files-out-of-golden-directory
branch
3 times, most recently
from
6b36414 to
fa0012c
Compare
smelc
reviewed
Nov 14, 2023
.github/workflows/haskell.yml
Outdated
| run: cabal test all | ||
| run: | | ||
| cabal test all | ||
| rm -rf cardano-cli/test/cardano-cli-golden/files/golden |
There was a problem hiding this comment.
I think this rm followed by rerunning the test suite should be explained by a comment.
It looks like an unusual pattern and we will forget why it's there in the future.
There was a problem hiding this comment.
Oh woow yeah I overlooked that. Windows is so unusual, my mind doesn't even consider it 😆
|
Did a first pass, @newhoggy> ping me when the CI passes, I'll have another look 👍 |
carbolymer
approved these changes
Nov 15, 2023
newhoggy
force-pushed
the
newhoggy/move-input-files-out-of-golden-directory
branch
4 times, most recently
from
070a4f3 to
b17f193
Compare
newhoggy
force-pushed
the
newhoggy/move-input-files-out-of-golden-directory
branch
from
b17f193 to
4db6514
Compare
Jimbo4350
approved these changes
Dec 12, 2023
| import qualified Hedgehog.Extras.Test.Golden as H | ||
|
|
||
| {- HLINT ignore "Use camelCase" -} | ||
|
|
||
| hprop_golden_shelleyGenesisInitialTxIn :: Property | ||
| hprop_golden_shelleyGenesisInitialTxIn = propertyOnce $ do | ||
| verificationKeyFile <- noteInputFile "test/cardano-cli-golden/files/input/shelley/keys/genesis_verification_keys/genesis-utxo.vkey" | ||
| goldenUtxoHashFile <- noteInputFile "test/cardano-cli-golden/files/golden/shelley/keys/genesis_utxo_hashes/utxo_hash" | ||
| goldenUtxoHashFile <- H.note "test/cardano-cli-golden/files/golden/shelley/keys/genesis_utxo_hashes/utxo_hash" |
There was a problem hiding this comment.
Did you intentionally not change golden -> input here?
There was a problem hiding this comment.
Yes because goldenUtxoHashFile is not used as an input file. The code before was misleading.
newhoggy
force-pushed
the
newhoggy/move-input-files-out-of-golden-directory
branch
from
4db6514 to
b351b1b
Compare
newhoggy
force-pushed
the
newhoggy/move-input-files-out-of-golden-directory
branch
from
b351b1b to
2381388
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Only golden files should live in the
goldendirectory.A new CI check has been added to enforce this.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist