Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action update-committee: add golden test #383

Closed
wants to merge 3 commits into from

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Oct 18, 2023

Changelog

- description: |
    action update-committee: add golden test
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #359

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • NA The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@smelc smelc added the test Modifies/extends the test suite label Oct 18, 2023
@smelc smelc force-pushed the smelc/test-governance-update-committee branch from 744889d to b6bd232 Compare October 18, 2023 15:46
@smelc
Copy link
Contributor Author

smelc commented Oct 19, 2023

Likely superseded by #391 in the end.

@smelc
Copy link
Contributor Author

smelc commented Nov 9, 2023

Closing as it will be superseded by #442 in the end.

@smelc smelc closed this Nov 9, 2023
@smelc smelc deleted the smelc/test-governance-update-committee branch February 1, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Modifies/extends the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a golden test of update-committee
1 participant